Issue 824013004: Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback

Issue 824013004: Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (Closed)

Created:
5 years, 11 months ago by reed2

Modified:
5 years, 11 months ago

Reviewers:
robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback (patchset #2 id:20001 of https://codereview.chromium.org/829983003/) Reason for revert: speculative revert to unblock DEPS roll Original issue's description: > Rename SkDrawPictureCallback to SkPicture::AbortCallback > > Committed: https://skia.googlesource.com/skia/+/7ef197255deb4e2fa64c03c7130d56ddf164e83c TBR=reed@google.com,robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8ea6dabbb15ef276645b7a6ebab44a4a532ac990

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -60 lines)			Patch
M	gyp/skia_for_android_framework_defines.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/skia_for_chromium_defines.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkDrawPictureCallback.h	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	include/core/SkPicture.h	View	4 chunks	+3 lines, -20 lines	0 comments	Download
M	src/core/SkPicture.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkPictureData.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkRecordDraw.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/core/SkRecordDraw.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/gpu/GrRecordReplaceDraw.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrRecordReplaceDraw.cpp	View	5 chunks	+15 lines, -15 lines	0 comments	Download
M	tests/RecordDrawTest.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/RecordReplaceDrawTest.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

reed2

Created Revert of Rename SkDrawPictureCallback to SkPicture::AbortCallback

5 years, 11 months ago (2015-01-07 00:14:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824013004/1

5 years, 11 months ago (2015-01-07 00:15:13 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-07 00:15:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8ea6dabbb15ef276645b7a6ebab44a4a532ac990