Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 824003004: Add type annotations to metadata_dispatcher.js. (Closed)

Created:
5 years, 12 months ago by yawano
Modified:
5 years, 12 months ago
Reviewers:
fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type annotations to metadata_dispatcher.js. BUG=444510 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/58af8f4de35388970be49fe5fa16c24610d8e813 Cr-Commit-Position: refs/heads/master@{#309625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -39 lines) Patch
A + ui/file_manager/externs/platform_worker.js View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +0 lines, -20 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/compiled_resources.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/id3_parser.js View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/image_parsers.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_dispatcher.js View 7 chunks +15 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_parser.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 12 months ago (2014-12-24 08:29:42 UTC) #2
fukino
On 2014/12/24 08:29:42, yawano wrote: > PTAL. Thank you! lgtm.
5 years, 12 months ago (2014-12-24 08:52:50 UTC) #3
yawano
On 2014/12/24 08:52:50, fukino wrote: > On 2014/12/24 08:29:42, yawano wrote: > > PTAL. Thank ...
5 years, 12 months ago (2014-12-24 08:53:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/824003004/1
5 years, 12 months ago (2014-12-24 08:54:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 09:33:40 UTC) #7
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 09:34:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58af8f4de35388970be49fe5fa16c24610d8e813
Cr-Commit-Position: refs/heads/master@{#309625}

Powered by Google App Engine
This is Rietveld 408576698