Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 823993004: Document the structure of the Media controls DOM (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Document the structure of the Media controls DOM MediaControls::initializeControls is a bit too long and dense to get a good feel of the DOM structure. Document the structure in a comment. BUG=447161 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188152

Patch Set 1 #

Patch Set 2 : Drop minor incorrectness. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M Source/core/html/shadow/MediaControls.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Maybe unnecessary, but I found it easier to grasp than the method itself (especially the ...
5 years, 11 months ago (2015-01-08 16:13:05 UTC) #2
philipj_slow
lgtm
5 years, 11 months ago (2015-01-09 14:52:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823993004/20001
5 years, 11 months ago (2015-01-09 14:54:03 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 15:09:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188152

Powered by Google App Engine
This is Rietveld 408576698