Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 823923002: [Chromecast] Add IPC code on brower process side (Closed)

Created:
6 years ago by erickung1
Modified:
5 years, 12 months ago
Reviewers:
lcwu1, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Add IPC code on brower process side BUG=408189 Committed: https://crrev.com/bf07219782b6a813ad2e08345a803deeb78e618c Cr-Commit-Position: refs/heads/master@{#309607}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+911 lines, -0 lines) Patch
A chromecast/browser/media/cma_message_filter_host.h View 1 chunk +126 lines, -0 lines 0 comments Download
A chromecast/browser/media/cma_message_filter_host.cc View 1 chunk +443 lines, -0 lines 0 comments Download
A chromecast/browser/media/cma_message_loop.h View 1 chunk +41 lines, -0 lines 0 comments Download
A chromecast/browser/media/cma_message_loop.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A chromecast/browser/media/media_pipeline_host.h View 1 chunk +85 lines, -0 lines 0 comments Download
A chromecast/browser/media/media_pipeline_host.cc View 1 1 chunk +178 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
erickung1
6 years ago (2014-12-23 22:16:50 UTC) #2
gunsch
lgtm % couple small comments. Thanks for getting this out right away! https://codereview.chromium.org/823923002/diff/1/chromecast/browser/media/media_pipeline_host.cc File chromecast/browser/media/media_pipeline_host.cc ...
6 years ago (2014-12-23 22:27:19 UTC) #3
erickung1
https://codereview.chromium.org/823923002/diff/1/chromecast/browser/media/media_pipeline_host.cc File chromecast/browser/media/media_pipeline_host.cc (right): https://codereview.chromium.org/823923002/diff/1/chromecast/browser/media/media_pipeline_host.cc#newcode77 chromecast/browser/media/media_pipeline_host.cc:77: new SharedMemoryChunk( On 2014/12/23 22:27:19, gunsch wrote: > nit: ...
6 years ago (2014-12-23 22:34:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823923002/20001
6 years ago (2014-12-23 22:35:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28687) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45420)
6 years ago (2014-12-23 22:42:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823923002/20001
5 years, 12 months ago (2014-12-24 01:52:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 12 months ago (2014-12-24 02:39:18 UTC) #11
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 02:40:06 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bf07219782b6a813ad2e08345a803deeb78e618c
Cr-Commit-Position: refs/heads/master@{#309607}

Powered by Google App Engine
This is Rietveld 408576698