Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 823853003: Enable logging in mojo:media app. (Closed)

Created:
6 years ago by xhwang
Modified:
5 years, 12 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable logging in mojo:media app. Example to enable logging in both html_viewer and media app: out/GN/mojo_shell http://<host>/bear-src-a.html --args-for='mojo://html_viewer --enable-mojo-media-renderer --vmodule=*mojo_render*=3' --args-for='mojo://media --vmodule=*service*=3' TBR=jamesr@chromium.org BUG=432998, 434802 TEST=See above. R=jrummell@chromium.org Committed: https://crrev.com/cc4dd67b73054f97707e04de95a1c7de3e3d9396 Cr-Commit-Position: refs/heads/master@{#309617}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M media/mojo/services/mojo_media_application.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xhwang
6 years ago (2014-12-23 18:50:38 UTC) #1
jrummell
lgtm.
6 years ago (2014-12-23 23:27:35 UTC) #2
xhwang
TBRing jamesr@ on the one line change in mojo/services/html_viewer/html_viewer.cc.
6 years ago (2014-12-23 23:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823853003/1
6 years ago (2014-12-23 23:37:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28721) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45447)
6 years ago (2014-12-23 23:47:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823853003/1
5 years, 12 months ago (2014-12-24 04:40:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 05:00:03 UTC) #10
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 05:00:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc4dd67b73054f97707e04de95a1c7de3e3d9396
Cr-Commit-Position: refs/heads/master@{#309617}

Powered by Google App Engine
This is Rietveld 408576698