Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 823763003: Fix crash after Launcher drag/drop (take 3 - no unit test) (Closed)

Created:
6 years ago by Greg Levin
Modified:
6 years ago
Reviewers:
jennyz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash after Launcher drag/drop (take 3 - no unit test) BUG=439055 TEST=In Launcher, drag app to solitary folder on second page Earlier versions of this CL included a unit test... https://codereview.chromium.org/780023002/ https://codereview.chromium.org/792883006/ ...but the slowness of valgrind kept screwing up the timing of the drag/drop, so I'm giving up on the unit test (which didn't actually test this bug anyway). Committed: https://crrev.com/e2a5c5df8bcc5571b451549cc8b6b4f99676b61b Cr-Commit-Position: refs/heads/master@{#309575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 chunk +12 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Greg Levin
One more time, without the unit test. Please have a quick look!
6 years ago (2014-12-23 17:14:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823763003/1
6 years ago (2014-12-23 17:41:15 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-23 17:41:17 UTC) #6
jennyz
lgtm
6 years ago (2014-12-23 18:51:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823763003/1
6 years ago (2014-12-23 18:52:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 19:45:55 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-23 19:46:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e2a5c5df8bcc5571b451549cc8b6b4f99676b61b
Cr-Commit-Position: refs/heads/master@{#309575}

Powered by Google App Engine
This is Rietveld 408576698