Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 823743002: Fix Flaky EncryptedMediaTest (Closed)

Created:
6 years ago by jrummell
Modified:
6 years ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Flaky EncryptedMediaTest Tests are flaky as setMediaKeys() was not completing before the "encrypted" event was generated. Change delays setting the video source until setMediaKeys() completes. BUG=444683 TEST=Failing tests run fine locally Committed: https://crrev.com/37edfbac393c04549884ec15ce612a376a5be6ff Cr-Commit-Position: refs/heads/master@{#309568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M media/test/data/eme_player_js/player_utils.js View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jrummell
PTAL.
6 years ago (2014-12-23 00:33:35 UTC) #2
xhwang
Is the failure Linux only? If not, drop the "Linux" part in the CL title. ...
6 years ago (2014-12-23 17:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823743002/1
6 years ago (2014-12-23 17:59:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 18:57:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/37edfbac393c04549884ec15ce612a376a5be6ff Cr-Commit-Position: refs/heads/master@{#309568}
6 years ago (2014-12-23 18:59:22 UTC) #7
jrummell
6 years ago (2014-12-23 22:51:00 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/826603002/ by jrummell@chromium.org.

The reason for reverting is: This changes introduces a new problem that is
breaking the builds (e.g.
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Brows....

Powered by Google App Engine
This is Rietveld 408576698