content/renderer/media/webrtc/peer_connection_dependency_factory.h - Issue 823713002: Standardize usage of virtual/override/final specifiers in content/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.h

Issue 823713002: Standardize usage of virtual/override/final specifiers in content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/input/input_scroll_elasticity_controller_unittest.cc ('k') | content/renderer/media/webrtc/video_destination_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/peer_connection_dependency_factory.h

diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.h b/content/renderer/media/webrtc/peer_connection_dependency_factory.h

index 9efbbe270ad51ecd945d8aee4c798187c854e2f3..8a9abe3285e4998aec2d736d04f94718d469cfd2 100644

--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.h

+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.h

@@ -61,7 +61,7 @@ class CONTENT_EXPORT PeerConnectionDependencyFactory

public:

PeerConnectionDependencyFactory(

P2PSocketDispatcher* p2p_socket_dispatcher);

- virtual ~PeerConnectionDependencyFactory();

+ ~PeerConnectionDependencyFactory() override;

// Create a RTCPeerConnectionHandler object that implements the

// WebKit WebRTCPeerConnectionHandler interface.

@@ -167,7 +167,7 @@ class CONTENT_EXPORT PeerConnectionDependencyFactory

// Implement base::MessageLoop::DestructionObserver.

// This makes sure the libjingle PeerConnectionFactory is released before

// the renderer message loop is destroyed.

- virtual void WillDestroyCurrentMessageLoop() override;

+ void WillDestroyCurrentMessageLoop() override;

// Creates |pc_factory_|, which in turn is used for

// creating PeerConnection objects.