Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 823703002: Check that dataReductionUpdateDailyLengths is reset. (Closed)

Created:
6 years ago by Not at Google. Contact bengr
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check that dataReductionUpdateDailyLengths is reset. Fix data reduction proxy browser tests to check that dataReductionUpdateDailyLengths is reset after date lengths are updated. BUG=384394 Committed: https://crrev.com/d77dccab40bd48b2d07d8d31269ee1b36449e589 Cr-Commit-Position: refs/heads/master@{#309498}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename drp and pp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -17 lines) Patch
M chrome/test/data/extensions/api_test/preference/data_reduction_proxy/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js View 1 7 chunks +32 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Not at Google. Contact bengr
6 years ago (2014-12-22 21:42:52 UTC) #2
bengr
lgtm with a nit. https://codereview.chromium.org/823703002/diff/1/chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js File chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js (right): https://codereview.chromium.org/823703002/diff/1/chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js#newcode9 chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js:9: var pp = chrome.preferencesPrivate; I'd ...
6 years ago (2014-12-22 21:57:21 UTC) #3
Not at Google. Contact bengr
https://codereview.chromium.org/823703002/diff/1/chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js File chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js (right): https://codereview.chromium.org/823703002/diff/1/chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js#newcode9 chrome/test/data/extensions/api_test/preference/data_reduction_proxy/test.js:9: var pp = chrome.preferencesPrivate; On 2014/12/22 21:57:21, bengr wrote: ...
6 years ago (2014-12-22 22:15:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823703002/20001
6 years ago (2014-12-22 22:53:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-23 00:11:58 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-23 00:12:54 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d77dccab40bd48b2d07d8d31269ee1b36449e589
Cr-Commit-Position: refs/heads/master@{#309498}

Powered by Google App Engine
This is Rietveld 408576698