Issue 823633003: Revert of ozone: xkb: Load keymaps on worker thread & cache them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 823633003: Revert of ozone: xkb: Load keymaps on worker thread & cache them (Closed)

Created:
5 years, 11 months ago by spang

Modified:
5 years, 11 months ago

Reviewers:
Shu Chen, FengYuan, kpschoedel

CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of ozone: xkb: Load keymaps on worker thread & cache them (patchset #17 id:310001 of https://codereview.chromium.org/817983002/) Reason for revert: Adds thread-unsafe code. Original issue's description: > ozone: xkb: Load keymaps on worker thread & cache them > > 1. Free xkb keymaps in the destructor. > 2. Moves kemap load into another worker thread. > 3. Adds keymap caching. > > BUG=430194 > > Committed: https://crrev.com/f0b38f78f146cedf336ac9ad0236f681833c7263 > Cr-Commit-Position: refs/heads/master@{#309928} TBR=shuchen@chromium.org,kpschoedel@chromium.org,fengyuan@chromium.org NOTREECHECKS=true NOTRY=true BUG=430194 Committed: https://crrev.com/99f0df5c221b3f489c848cb8a0f5d80099767515 Cr-Commit-Position: refs/heads/master@{#310105}

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -163 lines)			Patch
M	ui/events/ozone/layout/xkb/scoped_xkb.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h	View	4 chunks	+0 lines, -22 lines	0 comments	Download
M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc	View	7 chunks	+15 lines, -66 lines	0 comments	Download
M	ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc	View	2 chunks	+0 lines, -71 lines	0 comments	Download

Total messages: 4 (0 generated)

spang

Created Revert of ozone: xkb: Load keymaps on worker thread & cache them

5 years, 11 months ago (2015-01-06 17:38:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823633003/1

5 years, 11 months ago (2015-01-06 17:39:05 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-06 17:40:36 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/99f0df5c221b3f489c848cb8a0f5d80099767515
Cr-Commit-Position: refs/heads/master@{#310105}