Move util.loadImage and util.cancelLoadImage to thumbnail_loader.js.

Move util.loadImage and util.cancelLoadImage to thumbnail_loader.js.

util.loadImage and util.cancelLoadImage seem to be called only by thumbnail_loader.js. Since common/js/util.js is included by many applications, unnecessarily putting codes in common/js/util.js brings unnecessary dependencies.

BUG=433728
TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/gallery/js/compiled_resources.gyp && ninja -C out/Default

Committed: https://crrev.com/d0e9b7d3f2c1003e3236b3086df43f098b0436af
Cr-Commit-Position: refs/heads/master@{#309615}

[yawano, 2014-12-24 01:43:53]

yawano@chromium.org changed reviewers:
+ mtomasz@chromium.org

[yawano, 2014-12-24 01:43:53]

PTAL. Thank you!

[mtomasz, 2014-12-24 01:53:28]

https://codereview.chromium.org/823593006/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right):

https://codereview.chromium.org/823593006/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:132: * Load an
image.
IIUC this static method, as well as cancelLoadImage() are not supposed to be
called externally outside of ThumbnailLoader class. Since all they do is a
simple call how about just inlining the calls and removing these static methods?

[yawano, 2014-12-24 02:06:39]

Thank you for the review! PTAL.

https://codereview.chromium.org/823593006/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/thumbnail_loader.js (right):

https://codereview.chromium.org/823593006/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/thumbnail_loader.js:132: * Load an
image.
On 2014/12/24 01:53:28, mtomasz wrote:
> IIUC this static method, as well as cancelLoadImage() are not supposed to be
> called externally outside of ThumbnailLoader class. Since all they do is a
> simple call how about just inlining the calls and removing these static
methods?

Done.

[mtomasz, 2014-12-24 02:07:29]

lgtm

[yawano, 2014-12-24 02:08:07]

On 2014/12/24 02:07:29, mtomasz wrote:
> lgtm

Thank you!

[yawano, 2014-12-24 02:08:11]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-12-24 02:08:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/823593006/20001

[commit-bot: I haz the power, 2014-12-24 03:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 03:13:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yawano, 2014-12-24 03:52:23]

There was a bug in the error function which is passed, and fixed it. PTAL. Thank
you!

[mtomasz, 2014-12-24 03:54:17]

lgtm

[yawano, 2014-12-24 03:54:42]

On 2014/12/24 03:54:17, mtomasz wrote:
> lgtm

Thank you!

[yawano, 2014-12-24 03:54:45]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-12-24 03:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/823593006/40001

[commit-bot: I haz the power, 2014-12-24 04:37:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-24 04:38:33]

Patchset 3 (id:??) landed as
https://crrev.com/d0e9b7d3f2c1003e3236b3086df43f098b0436af
Cr-Commit-Position: refs/heads/master@{#309615}