Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 823583005: Add type annotations to caster.js. (Closed)

Created:
5 years, 12 months ago by yawano
Modified:
5 years, 12 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add type annotations to caster.js. BUG=444485 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/video_player/js/compiled_resources.gyp && ninja -C out/Default | grep "caster.js" Committed: https://crrev.com/ac340a287a4efa9febff64a3c62cf1e1f1d96ca4 Cr-Commit-Position: refs/heads/master@{#309623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M ui/file_manager/externs/chrome_cast.js View 1 chunk +2 lines, -1 line 0 comments Download
M ui/file_manager/video_player/js/cast/caster.js View 5 chunks +10 lines, -3 lines 0 comments Download
M ui/file_manager/video_player/js/error_util.js View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 12 months ago (2014-12-24 06:34:41 UTC) #2
yoshiki
lgtm
5 years, 12 months ago (2014-12-24 07:47:47 UTC) #3
yawano
On 2014/12/24 07:47:47, yoshiki wrote: > lgtm Thank you!
5 years, 12 months ago (2014-12-24 07:48:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823583005/1
5 years, 12 months ago (2014-12-24 07:49:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 08:34:30 UTC) #7
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 08:35:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac340a287a4efa9febff64a3c62cf1e1f1d96ca4
Cr-Commit-Position: refs/heads/master@{#309623}

Powered by Google App Engine
This is Rietveld 408576698