Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 823583003: Enable the embedder to specify what kind of context was disposed (Closed)

Created:
6 years ago by jochen (gone - plz use gerrit)
Modified:
6 years ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable the embedder to specify what kind of context was disposed This API is used by Blink to inform V8 about HTML frames being disposed. Using the optional parameter, Blink can tell V8 whether the disposed frame was a main frame. In that case, we might want to reset GC parameters BUG=none R=hpayer@chromium.org LOG=y Committed: https://crrev.com/18b1e6d353501a30a750ac12da68bdc0f93b923e Cr-Commit-Position: refs/heads/master@{#25926}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M include/v8.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
6 years ago (2014-12-22 13:55:36 UTC) #1
Hannes Payer (out of office)
lgtm, thx
6 years ago (2014-12-22 13:58:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823583003/1
6 years ago (2014-12-22 14:00:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 14:27:28 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-22 14:27:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18b1e6d353501a30a750ac12da68bdc0f93b923e
Cr-Commit-Position: refs/heads/master@{#25926}

Powered by Google App Engine
This is Rietveld 408576698