Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 823573002: Fix assertions for the dSYM producer in asan_symbolize.py (Closed)

Created:
6 years ago by Alexander Potapenko
Modified:
6 years ago
Reviewers:
earthdok
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assertions for the dSYM producer in asan_symbolize.py (according to issue 444343 there can be nested frameworks) BUG=444343 TBR=earthdok@chromium.org NOTRY=true Committed: https://crrev.com/bd9874ec5a46c8af7f67132d40ac1fea191ba242 Cr-Commit-Position: refs/heads/master@{#309426}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix the condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/valgrind/asan/asan_symbolize.py View 1 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Alexander Potapenko
TBR
6 years ago (2014-12-22 11:41:09 UTC) #1
earthdok
https://codereview.chromium.org/823573002/diff/1/tools/valgrind/asan/asan_symbolize.py File tools/valgrind/asan/asan_symbolize.py (right): https://codereview.chromium.org/823573002/diff/1/tools/valgrind/asan/asan_symbolize.py#newcode78 tools/valgrind/asan/asan_symbolize.py:78: assert (not (len(app_positions) >= 1 and app_positions + framework_positions ...
6 years ago (2014-12-22 14:00:37 UTC) #2
Alexander Potapenko
https://codereview.chromium.org/823573002/diff/1/tools/valgrind/asan/asan_symbolize.py File tools/valgrind/asan/asan_symbolize.py (right): https://codereview.chromium.org/823573002/diff/1/tools/valgrind/asan/asan_symbolize.py#newcode78 tools/valgrind/asan/asan_symbolize.py:78: assert (not (len(app_positions) >= 1 and On 2014/12/22 14:00:37, ...
6 years ago (2014-12-22 15:01:45 UTC) #3
earthdok
lgtm
6 years ago (2014-12-22 15:08:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823573002/20001
6 years ago (2014-12-22 15:11:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-22 15:12:03 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 15:12:47 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bd9874ec5a46c8af7f67132d40ac1fea191ba242
Cr-Commit-Position: refs/heads/master@{#309426}

Powered by Google App Engine
This is Rietveld 408576698