Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6213)

Unified Diff: extensions/browser/api/guest_view/guest_view_internal_api.cc

Issue 823543003: AppView: Fix owner_extension_id (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/guest_view/guest_view_internal_api.cc
diff --git a/extensions/browser/api/guest_view/guest_view_internal_api.cc b/extensions/browser/api/guest_view/guest_view_internal_api.cc
index dbbfb725feb563bcdcc727af63bcc8cf26126f1d..fa4201e2e005ec88bacc1e33769faad354359796 100644
--- a/extensions/browser/api/guest_view/guest_view_internal_api.cc
+++ b/extensions/browser/api/guest_view/guest_view_internal_api.cc
@@ -39,14 +39,8 @@ bool GuestViewInternalCreateGuestFunction::RunAsync() {
error_ = "Guest views can only be embedded in web content";
return false;
}
- // If the guest is an <extensionoptions> to be embedded in a WebUI, then
- // there is no extension, and extension() will be null. Use an empty string
- // instead.
- std::string embedder_extension_id =
- extension() ? extension_id() : std::string();
guest_view_manager->CreateGuest(view_type,
- embedder_extension_id,
owner_web_contents,
*create_params,
callback);

Powered by Google App Engine
This is Rietveld 408576698