Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 823543003: AppView: Fix owner_extension_id (Closed)

Created:
6 years ago by Fady Samuel
Modified:
5 years, 12 months ago
Reviewers:
lfg
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AppView: Fix owner_extension_id Set the owner_extension_id in GuestViewBase::Init so that it's available in request.embedderExtensionId in onEmbedRequested in the app to be embedded. This also simplifies code in GuestViewBase a bit. BUG=444749 TBR=rockot@chromium.org for guest_view_internal_api.cc Committed: https://crrev.com/840c1af1a7a55dde57b6f22423487dd369bfe19d Cr-Commit-Position: refs/heads/master@{#309600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -36 lines) Patch
M chrome/test/data/extensions/platform_apps/app_view/shim/skeleton/main.js View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/browser/extension_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 2 chunks +3 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 6 chunks +12 lines, -15 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/guest_view_manager.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Fady Samuel
6 years ago (2014-12-23 19:43:56 UTC) #2
lfg
lgtm
6 years ago (2014-12-23 19:47:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823543003/1
6 years ago (2014-12-23 20:02:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/28788)
6 years ago (2014-12-23 20:11:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823543003/1
6 years ago (2014-12-23 21:21:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/45577)
6 years ago (2014-12-23 21:35:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823543003/1
6 years ago (2014-12-23 21:42:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45385)
6 years ago (2014-12-23 21:50:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823543003/1
6 years ago (2014-12-24 00:13:33 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28736)
6 years ago (2014-12-24 00:21:47 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823543003/1
6 years ago (2014-12-24 01:19:03 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 01:40:10 UTC) #22
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 01:41:11 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/840c1af1a7a55dde57b6f22423487dd369bfe19d
Cr-Commit-Position: refs/heads/master@{#309600}

Powered by Google App Engine
This is Rietveld 408576698