chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc - Issue 823533004: Move memory histograms generation to MetricsMemoryDetails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

Issue 823533004: Move memory histograms generation to MetricsMemoryDetails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clang-format Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

diff --git a/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc b/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

index 1d2e34c85e41f942ac9c00df84cea85477a3a02a..21c5766f2b079ff37ae79e3a09a78e6e57816fbd 100644

--- a/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

+++ b/chrome/browser/feedback/system_logs/log_sources/memory_details_log_source.cc

@@ -45,8 +45,7 @@ void MemoryDetailsLogSource::Fetch(const SysLogsSourceCallback& callback) {

scoped_refptr<SystemLogsMemoryHandler>

handler(new SystemLogsMemoryHandler(callback));

- // TODO(jamescook): Maybe we don't need to update histograms here?

- handler->StartFetch(MemoryDetails::UPDATE_USER_METRICS);

+ handler->StartFetch();

Ilya Sherman 2015/01/16 04:57:36 Are you sure that updating the histograms is not i

Alexei Svitkine (slow) 2015/01/16 16:07:49 Yes, see line 24 in this file - ToLogString() is w

}

} // namespace system_logs

« no previous file with comments | « chrome/browser/chromeos/memory/oom_priority_manager.cc ('k') | chrome/browser/memory_details.h » ('j') | chrome/browser/memory_details.cc » ('J')