Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 823533004: Move memory histograms generation to MetricsMemoryDetails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better class comment. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index ef588c1ac80a65f8d9db6b6fb35fc5158ecf2880..d8d05a4f536dc876f81d423e99a02c4908ea436b 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -97,29 +97,6 @@ metrics::SystemProfileProto::Channel AsProtobufChannel(
return metrics::SystemProfileProto::CHANNEL_UNKNOWN;
}
-// Handles asynchronous fetching of memory details.
-// Will run the provided task after finished.
-class MetricsMemoryDetails : public MemoryDetails {
- public:
- MetricsMemoryDetails(
- const base::Closure& callback,
- MemoryGrowthTracker* memory_growth_tracker)
- : callback_(callback) {
- SetMemoryGrowthTracker(memory_growth_tracker);
- }
-
- void OnDetailsAvailable() override {
- base::MessageLoop::current()->PostTask(FROM_HERE, callback_);
- }
-
- private:
- ~MetricsMemoryDetails() override {}
-
- base::Closure callback_;
-
- DISALLOW_COPY_AND_ASSIGN(MetricsMemoryDetails);
-};
-
} // namespace
ChromeMetricsServiceClient::ChromeMetricsServiceClient(
@@ -247,7 +224,7 @@ void ChromeMetricsServiceClient::CollectFinalMetrics(
scoped_refptr<MetricsMemoryDetails> details(
new MetricsMemoryDetails(callback, &memory_growth_tracker_));
- details->StartFetch(MemoryDetails::UPDATE_USER_METRICS);
+ details->StartFetch();
// Collect WebCore cache information to put into a histogram.
for (content::RenderProcessHost::iterator i(
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | chrome/browser/metrics/metrics_memory_details.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698