Move more webdata unittests into components_unittests target.

components/components_tests.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # This turns on e.g. the filename-based detection of which
     # platforms to include source files on (e.g. files ending in
     # _mac.h or _mac.cc are only compiled on MacOSX).
     'chromium_code': 1,
    },
   'conditions': [
     ['android_webview_build == 0', {
       'targets': [
         {
+          'target_name': 'components_unittests_strings',

[tony, 2013/11/24 04:24:07]

Nit: I would probably name the file something like components_test_pak and the
filename something like components_test.pak like you did with
ui_test_pak/ui_test.pak.

[tfarina, 2013/11/24 17:19:41]

Done.

+          'type': 'none',
+          'dependencies': [
+            'component_strings.gyp:component_strings',
+          ],
+          'variables': {
+            'repack_path': '../tools/grit/grit/format/repack.py',
+          },
+          'actions': [
+            {
+              'action_name': 'repack_components_unittests_strings',
+              'variables': {
+                'pak_inputs': [
+                  '<(SHARED_INTERMEDIATE_DIR)/components/strings/component_strings_en-US.pak',
+                  '<(SHARED_INTERMEDIATE_DIR)/ui/app_locale_settings/app_locale_settings_en-US.pak',

[tfarina, 2013/11/23 23:20:30]

I had to add this line, otherwise ResourceBundle does not find
IDS_UI_FONT_FAMILY_CROS.

[tony, 2013/11/24 04:24:07]

That's fine, but should this target depend on
ui/base/strings/ui_strings.gyp:ui_strings?

[tfarina, 2013/11/24 17:19:41]

I added, thanks for catching this. I think it will be necessary, in order to
generate the app_locale_settings_en-US.pak.

+                ],
+              },
+              'inputs': [
+                '<(repack_path)',
+                '<@(pak_inputs)',
+              ],
+              'outputs': [
+                '<(PRODUCT_DIR)/components/strings/component_strings_en-US.pak',
+              ],
+              'action': ['python', '<(repack_path)', '<@(_outputs)',
+                         '<@(pak_inputs)'],
+            },
+          ],
+        },
+        {
           'target_name': 'components_unittests',
           'type': '<(gtest_target_type)',
           'sources': [
             'auto_login_parser/auto_login_parser_unittest.cc',
             'autofill/core/browser/webdata/autofill_entry_unittest.cc',
+            'autofill/core/browser/webdata/autofill_table_unittest.cc',
+            'autofill/core/browser/webdata/web_data_service_unittest.cc',
             'autofill/core/common/form_data_unittest.cc',
             'autofill/core/common/form_field_data_unittest.cc',
             'autofill/core/common/password_form_fill_data_unittest.cc',
             'browser_context_keyed_service/browser_context_dependency_manager_unittest.cc',
             'browser_context_keyed_service/dependency_graph_unittest.cc',
             'dom_distiller/core/article_entry_unittest.cc',
             'dom_distiller/core/distiller_unittest.cc',
             'dom_distiller/core/distiller_url_fetcher_unittest.cc',
             'dom_distiller/core/dom_distiller_database_unittest.cc',
             'dom_distiller/core/dom_distiller_model_unittest.cc',
@@ skipping 25 matching lines @@
           ],
           'include_dirs': [
             '..',
           ],
           'dependencies': [
             '../base/base.gyp:test_support_base',
             '../sync/sync.gyp:sync',
             '../testing/gmock.gyp:gmock',
             '../testing/gtest.gyp:gtest',
 
+            'components_unittests_strings',
+
             # Dependencies of autofill
             'components.gyp:autofill_core_browser',
             'components.gyp:autofill_core_common',
 
             # Dependencies of auto_login_parser
             'components.gyp:auto_login_parser',
 
             # Dependencies of browser_context_keyed_service
             'components.gyp:browser_context_keyed_service',
 
@@ skipping 221 matching lines @@
               'dependencies': [
                 '../base/allocator/allocator.gyp:allocator',
               ],
             }],
           ],
         },
       ],
     }],
   ],
 }