PDF: Fix missing character when selecting backwards

PDF: Fix missing character when selecting backwards

When selecting backwards across page boundaries, the character count for
the start page of the text selection was one character short. Add one to
the character count to fix the selection.

BUG=445307
Committed: https://crrev.com/6989b943b34eab8ff10aada9a0b9ce6f472919e8
Cr-Commit-Position: refs/heads/master@{#311870}

[Deepak, 2015-01-15 12:04:13]

deepak.m1@samsung.com changed reviewers:
+ gene@chromium.org, thestig@chromium.org

[Deepak, 2015-01-15 12:04:14]

PTAL at my changes.
Thanks

[Deepak, 2015-01-16 05:23:23]

@thestig and @gene
PTAL at my changes.
Thanks

[Deepak, 2015-01-16 06:01:03]

deepak.m1@samsung.com changed reviewers:
+ raymes@chromium.org

[Lei Zhang, 2015-01-16 07:01:23]

lgtm, but your CL description is a bit too specific. How about generalizing it?

----
PDF: Fix missing character when selecting backwards

When selecting backwards across page boundaries, the character count for
the start page of the text selection was one character short. Add one to
the character count to fix the selection.
----

https://codereview.chromium.org/823523005/diff/20001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/823523005/diff/20001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1866: // As char_index starts from 0 so char count
should be set one more than
I would write this as:

The selection's char_index is 0-based, so the character count is one more than
the index. The character count needs to be negative to indicate a backwards
selection.

[Deepak, 2015-01-16 07:10:40]

Thanks for review.
I have updated comments and issue description.
Thanks

https://codereview.chromium.org/823523005/diff/20001/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/823523005/diff/20001/pdf/pdfium/pdfium_engine...
pdf/pdfium/pdfium_engine.cc:1866: // As char_index starts from 0 so char count
should be set one more than
On 2015/01/16 07:01:23, Lei Zhang wrote:
> I would write this as:
> 
> The selection's char_index is 0-based, so the character count is one more than
> the index. The character count needs to be negative to indicate a backwards
> selection.

Done.

[Deepak, 2015-01-16 07:10:45]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-01-16 07:11:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/823523005/40001

[commit-bot: I haz the power, 2015-01-16 08:24:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-16 08:24:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Deepak, 2015-01-16 09:26:05]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-01-16 09:27:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/823523005/40001

[commit-bot: I haz the power, 2015-01-16 09:27:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-16 09:27:41]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Deepak, 2015-01-16 09:30:08]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-01-16 09:31:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/823523005/40001

[commit-bot: I haz the power, 2015-01-16 11:38:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-16 11:40:31]

Patchset 3 (id:??) landed as
https://crrev.com/6989b943b34eab8ff10aada9a0b9ce6f472919e8
Cr-Commit-Position: refs/heads/master@{#311870}