Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 823403002: replace COMPILE_ASSERT with static_assert in skia/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
Stephen White
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in skia/ BUG=442514 Committed: https://crrev.com/c17d133b74e5c53ae4a7bec73fc46e208702164e Cr-Commit-Position: refs/heads/master@{#310027}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M skia/ext/convolver.h View 1 chunk +2 lines, -1 line 0 comments Download
M skia/ext/skia_utils_win.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@Stephen: please take a look.
5 years, 11 months ago (2015-01-05 22:01:43 UTC) #2
Stephen White
LGTM, bots willing
5 years, 11 months ago (2015-01-05 22:19:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823403002/20001
5 years, 11 months ago (2015-01-05 23:52:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 01:28:21 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 01:29:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c17d133b74e5c53ae4a7bec73fc46e208702164e
Cr-Commit-Position: refs/heads/master@{#310027}

Powered by Google App Engine
This is Rietveld 408576698