Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: content/common/content_client.h

Issue 8234013: Add a content::GetUserAgent() to wrap webkit_glue::GetUserAgent() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clarify requirements around GetUserAgent Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/about_page_handler.cc ('k') | content/common/content_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/content_client.h
diff --git a/content/common/content_client.h b/content/common/content_client.h
index ad07400cf9a2604674e32003c960fc87ce6edc04..154646b6bdc493497bfae7622f3406cd8d5dd96e 100644
--- a/content/common/content_client.h
+++ b/content/common/content_client.h
@@ -44,6 +44,16 @@ class ContentUtilityClient;
CONTENT_EXPORT void SetContentClient(ContentClient* client);
CONTENT_EXPORT ContentClient* GetContentClient();
+// Returns the user agent string being used by the browser. SetContentClient()
+// must be called prior to calling this, and this routine must be used
+// instead of webkit_glue::GetUserAgent() in order to ensure that we use
+// the same user agent string everywhere.
+// TODO(dpranke): This is caused by webkit_glue being a library that can
+// get linked into multiple linkable objects, causing us to have multiple
+// static values of the user agent. This will be fixed when we clean up
+// webkit_glue.
+CONTENT_EXPORT const std::string& GetUserAgent(const GURL& url);
+
// Interface that the embedder implements.
class CONTENT_EXPORT ContentClient {
public:
« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/about_page_handler.cc ('k') | content/common/content_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698