Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 8234013: Add a content::GetUserAgent() to wrap webkit_glue::GetUserAgent() (Closed)

Created:
9 years, 2 months ago by Dirk Pranke
Modified:
9 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, idana, Raghu Simha, dpranke+watch-content_chromium.org, jam, ncarter (slow), joi+watch-content_chromium.org, darin-cc_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Add a content::GetUserAgent() to wrap webkit_glue::GetUserAgent(), so that we get the glue statics linked into content.dll when we enable the content component build. R=jam@chromium.org BUG=90422 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105203

Patch Set 1 #

Total comments: 2

Patch Set 2 : clarify requirements around GetUserAgent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -13 lines) Patch
M chrome/browser/io_thread.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/device_management_service.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M content/common/content_client.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/common/content_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
9 years, 2 months ago (2011-10-11 18:58:56 UTC) #1
jam
lgtm
9 years, 2 months ago (2011-10-11 19:32:37 UTC) #2
Peter Kasting
http://codereview.chromium.org/8234013/diff/1/content/common/content_client.h File content/common/content_client.h (right): http://codereview.chromium.org/8234013/diff/1/content/common/content_client.h#newcode50 content/common/content_client.h:50: // consistent. Nit: "things are consistent" is pretty vague... ...
9 years, 2 months ago (2011-10-11 20:07:36 UTC) #3
Dirk Pranke
Mattias, can I get an owner review for the chrome/browser/policy change? Will, can I get ...
9 years, 2 months ago (2011-10-11 23:03:16 UTC) #4
akalin
sync LGTM On 2011/10/11 23:03:16, Dirk Pranke wrote: > Mattias, can I get an owner ...
9 years, 2 months ago (2011-10-11 23:05:48 UTC) #5
willchan no longer on Chromium
LGTM On Tue, Oct 11, 2011 at 4:05 PM, <akalin@chromium.org> wrote: > sync LGTM > ...
9 years, 2 months ago (2011-10-12 00:12:07 UTC) #6
Mattias Nissler (ping if slow)
9 years, 2 months ago (2011-10-12 09:03:06 UTC) #7
chrome/browser/policy LGTM

Powered by Google App Engine
This is Rietveld 408576698