Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: components/history/core/browser/history_types.h

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/history_ui_browsertest.cc ('k') | components/history/core/browser/history_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_types.h
diff --git a/components/history/core/browser/history_types.h b/components/history/core/browser/history_types.h
index a5c8fe5c05948d97db9c622913c41da3d5cf6f83..a8fedd0a3c2932f9d29fd7ffcc49591d911353c0 100644
--- a/components/history/core/browser/history_types.h
+++ b/components/history/core/browser/history_types.h
@@ -44,8 +44,9 @@ typedef int64 FaviconBitmapID; // Identifier for a bitmap in a favicon.
typedef int64 SegmentID; // URL segments for the most visited view.
typedef int64 IconMappingID; // For page url and icon mapping.
-// Identifier for a context to scope page ids. (ContextIDs are used in
-// comparisons only and are never dereferenced.)
+// Identifier for a context to scope the lifetime of navigation entry
+// references. (ContextIDs are used in comparisons only and are never
+// dereferenced.)
// NB: The use of WebContents here is temporary; when the dependency on content
// is broken, some other type will take its place.
typedef content::WebContents* ContextID;
@@ -379,7 +380,7 @@ struct HistoryAddPageArgs {
HistoryAddPageArgs(const GURL& url,
base::Time time,
ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& referrer,
const history::RedirectList& redirects,
ui::PageTransition transition,
@@ -389,10 +390,8 @@ struct HistoryAddPageArgs {
GURL url;
base::Time time;
-
ContextID context_id;
- int32 page_id;
-
+ int nav_entry_id;
GURL referrer;
history::RedirectList redirects;
ui::PageTransition transition;
« no previous file with comments | « chrome/test/data/webui/history_ui_browsertest.cc ('k') | components/history/core/browser/history_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698