Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: components/history/core/browser/history_types.cc

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_types.cc
diff --git a/components/history/core/browser/history_types.cc b/components/history/core/browser/history_types.cc
index 8dd6312d54fa1aab9e437c8b41bd7840f1025abc..72949b3fcd5803e9c8253fc04f85aef67b5cde71 100644
--- a/components/history/core/browser/history_types.cc
+++ b/components/history/core/browser/history_types.cc
@@ -240,17 +240,22 @@ TopSitesDelta::~TopSitesDelta() {}
// HistoryAddPageArgs ---------------------------------------------------------
HistoryAddPageArgs::HistoryAddPageArgs()
- : context_id(NULL),
- page_id(0),
- transition(ui::PAGE_TRANSITION_LINK),
- visit_source(SOURCE_BROWSED),
- did_replace_entry(false) {}
+ : HistoryAddPageArgs(GURL(),
+ base::Time(),
+ nullptr,
+ 0,
+ GURL(),
+ history::RedirectList(),
+ ui::PAGE_TRANSITION_LINK,
+ SOURCE_BROWSED,
+ false) {
+}
HistoryAddPageArgs::HistoryAddPageArgs(
const GURL& url,
base::Time time,
ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& referrer,
const history::RedirectList& redirects,
ui::PageTransition transition,
@@ -259,7 +264,7 @@ HistoryAddPageArgs::HistoryAddPageArgs(
: url(url),
time(time),
context_id(context_id),
- page_id(page_id),
+ nav_entry_id(nav_entry_id),
referrer(referrer),
redirects(redirects),
transition(transition),

Powered by Google App Engine
This is Rietveld 408576698