chrome/test/data/webui/history_ui_browsertest.cc - Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/history_ui_browsertest.cc

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: using Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/history_ui_browsertest.h ('k') | components/history/core/browser/history_types.h » ('j') | components/history/core/browser/history_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/history_ui_browsertest.cc

diff --git a/chrome/test/data/webui/history_ui_browsertest.cc b/chrome/test/data/webui/history_ui_browsertest.cc

index 947733880f87549f7b692c98ab3233d44843b4ae..7fe7038fddc080d5dc465010e5b2622f558d7ea4 100644

--- a/chrome/test/data/webui/history_ui_browsertest.cc

+++ b/chrome/test/data/webui/history_ui_browsertest.cc

@@ -16,7 +16,7 @@

HistoryUIBrowserTest::HistoryUIBrowserTest()

: history_(NULL),

baseline_time_(base::Time::Now().LocalMidnight()),

- page_id_(0) {

+ nav_entry_id_(0) {

}

HistoryUIBrowserTest::~HistoryUIBrowserTest() {

@@ -37,7 +37,7 @@ void HistoryUIBrowserTest::AddPageToHistory(

base::Time time = baseline_time_ + base::TimeDelta::FromHours(hour_offset);

GURL gurl = GURL(url);

- history_->AddPage(gurl, time, id_scope, page_id_++, GURL(),

+ history_->AddPage(gurl, time, id_scope, nav_entry_id_++, GURL(),

history::RedirectList(), ui::PAGE_TRANSITION_LINK,

history::SOURCE_BROWSED, false);

history_->SetPageTitle(gurl, base::UTF8ToUTF16(title));