chrome/browser/history/visit_tracker_unittest.cc - Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/visit_tracker_unittest.cc

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: using Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/visit_tracker.cc ('k') | chrome/browser/sync/test/integration/typed_urls_helper.cc » ('j') | components/history/core/browser/history_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/visit_tracker_unittest.cc

diff --git a/chrome/browser/history/visit_tracker_unittest.cc b/chrome/browser/history/visit_tracker_unittest.cc

index 4ed609ccd76fc9231c0ed2c2cc6e6356ae5e193c..08180bfb1c5bf4c2fda496f45203ed2ffaef7832 100644

--- a/chrome/browser/history/visit_tracker_unittest.cc

+++ b/chrome/browser/history/visit_tracker_unittest.cc

@@ -14,7 +14,7 @@ namespace {

struct VisitToTest {

// Identifies the context.

int context_id_int;

- int32 page_id;

+ int nav_entry_id;

// Used when adding this to the tracker

const char* url;

@@ -35,12 +35,12 @@ void RunTest(VisitTracker* tracker, VisitToTest* test, int test_count) {

// Check the referrer for this visit.

history::VisitID ref_visit = tracker->GetLastVisit(

- context_id, test[i].page_id, GURL(test[i].referrer));

+ context_id, test[i].nav_entry_id, GURL(test[i].referrer));

EXPECT_EQ(test[i].referring_visit_id, ref_visit);

// Now add this visit.

tracker->AddVisit(

- context_id, test[i].page_id, GURL(test[i].url), test[i].visit_id);

+ context_id, test[i].nav_entry_id, GURL(test[i].url), test[i].visit_id);

}