Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Unified Diff: chrome/browser/history/visit_tracker.h

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/visit_tracker.h
diff --git a/chrome/browser/history/visit_tracker.h b/chrome/browser/history/visit_tracker.h
index 890a889a0298d8a3df3d839aa006bc0db7d1baad..e3d1c7373133f24096553d68c4ac9c5d790eb263 100644
--- a/chrome/browser/history/visit_tracker.h
+++ b/chrome/browser/history/visit_tracker.h
@@ -26,7 +26,7 @@ class VisitTracker {
// Notifications -------------------------------------------------------------
void AddVisit(ContextID context_id,
- int32 page_id,
+ int nav_entry_id,
const GURL& url,
VisitID visit_id);
@@ -39,12 +39,14 @@ class VisitTracker {
// Returns the visit ID for the transition given information about the visit
// supplied by the renderer. We will return 0 if there is no appropriate
// referring visit.
- VisitID GetLastVisit(ContextID context_id, int32 page_id, const GURL& url);
+ VisitID GetLastVisit(ContextID context_id,
+ int nav_entry_id,
+ const GURL& url);
private:
struct Transition {
GURL url; // URL that the event happened to.
- int32 page_id; // ID generated by the render process host.
+ int nav_entry_id; // ID of the navigation entry.
VisitID visit_id; // Visit ID generated by history.
};
typedef std::vector<Transition> TransitionList;

Powered by Google App Engine
This is Rietveld 408576698