chrome/browser/history/history_service.cc - Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_service.cc

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: using Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_tab_helper.h » ('j') | components/history/core/browser/history_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/history_service.cc

diff --git a/chrome/browser/history/history_service.cc b/chrome/browser/history/history_service.cc

index ea860614bae271488bf4f517ea544ee2d3b9f20d..bd795bef549f677a53710e33480056538c1eeb98 100644

--- a/chrome/browser/history/history_service.cc

+++ b/chrome/browser/history/history_service.cc

@@ -392,7 +392,7 @@ void HistoryService::SetOnBackendDestroyTask(const base::Closure& task) {

void HistoryService::AddPage(const GURL& url,

Time time,

history::ContextID context_id,

- int32 page_id,

+ int nav_entry_id,

const GURL& referrer,

const history::RedirectList& redirects,

ui::PageTransition transition,

@@ -400,7 +400,7 @@ void HistoryService::AddPage(const GURL& url,

bool did_replace_entry) {

DCHECK(thread_checker_.CalledOnValidThread());

AddPage(

- history::HistoryAddPageArgs(url, time, context_id, page_id, referrer,

+ history::HistoryAddPageArgs(url, time, context_id, nav_entry_id, referrer,

redirects, transition, visit_source,

did_replace_entry));

}

@@ -465,13 +465,13 @@ void HistoryService::SetPageTitle(const GURL& url,

}

void HistoryService::UpdateWithPageEndTime(history::ContextID context_id,

- int32 page_id,

+ int nav_entry_id,

const GURL& url,

Time end_ts) {

DCHECK(thread_) << "History service being called after cleanup";

DCHECK(thread_checker_.CalledOnValidThread());

ScheduleAndForget(PRIORITY_NORMAL, &HistoryBackend::UpdateWithPageEndTime,

- context_id, page_id, url, end_ts);

+ context_id, nav_entry_id, url, end_ts);

}

void HistoryService::AddPageWithDetails(const GURL& url,

« no previous file with comments | « chrome/browser/history/history_service.h ('k') | chrome/browser/history/history_tab_helper.h » ('j') | components/history/core/browser/history_types.h » ('J')