Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/history/history_backend_unittest.cc

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: using Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend_unittest.cc
diff --git a/chrome/browser/history/history_backend_unittest.cc b/chrome/browser/history/history_backend_unittest.cc
index cbbcac4260dd0f54948363db0946dc46a7fe4bac..e9d32d86a763b9a54a6a4da0377e1bc9fcc746a1 100644
--- a/chrome/browser/history/history_backend_unittest.cc
+++ b/chrome/browser/history/history_backend_unittest.cc
@@ -309,15 +309,15 @@ class HistoryBackendTest : public HistoryBackendTestBase {
~HistoryBackendTest() override {}
protected:
- void AddRedirectChain(const char* sequence[], int page_id) {
- AddRedirectChainWithTransitionAndTime(sequence, page_id,
+ void AddRedirectChain(const char* sequence[], int nav_entry_id) {
+ AddRedirectChainWithTransitionAndTime(sequence, nav_entry_id,
ui::PAGE_TRANSITION_LINK,
Time::Now());
}
void AddRedirectChainWithTransitionAndTime(
const char* sequence[],
- int page_id,
+ int nav_entry_id,
ui::PageTransition transition,
base::Time time) {
history::RedirectList redirects;
@@ -326,7 +326,7 @@ class HistoryBackendTest : public HistoryBackendTestBase {
ContextID context_id = reinterpret_cast<ContextID>(1);
history::HistoryAddPageArgs request(
- redirects.back(), time, context_id, page_id, GURL(),
+ redirects.back(), time, context_id, nav_entry_id, GURL(),
redirects, transition, history::SOURCE_BROWSED,
true);
backend_->AddPage(request);

Powered by Google App Engine
This is Rietveld 408576698