Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: chrome/browser/history/history_tab_helper.h

Issue 823273003: Switch the history backend from using page ids to navigation entry unique ids. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_
6 #define CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_ 6 #define CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_
7 7
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/time/time.h" 9 #include "base/time/time.h"
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
(...skipping 18 matching lines...) Expand all
29 // Sends the page title to the history service. This is called when we receive 29 // Sends the page title to the history service. This is called when we receive
30 // the page title and we know we want to update history. 30 // the page title and we know we want to update history.
31 void UpdateHistoryPageTitle(const content::NavigationEntry& entry); 31 void UpdateHistoryPageTitle(const content::NavigationEntry& entry);
32 32
33 // Returns the history::HistoryAddPageArgs to use for adding a page to 33 // Returns the history::HistoryAddPageArgs to use for adding a page to
34 // history. 34 // history.
35 history::HistoryAddPageArgs CreateHistoryAddPageArgs( 35 history::HistoryAddPageArgs CreateHistoryAddPageArgs(
36 const GURL& virtual_url, 36 const GURL& virtual_url,
37 base::Time timestamp, 37 base::Time timestamp,
38 bool did_replace_entry, 38 bool did_replace_entry,
39 int nav_entry_id,
39 const content::FrameNavigateParams& params); 40 const content::FrameNavigateParams& params);
40 41
41 private: 42 private:
42 explicit HistoryTabHelper(content::WebContents* web_contents); 43 explicit HistoryTabHelper(content::WebContents* web_contents);
43 friend class content::WebContentsUserData<HistoryTabHelper>; 44 friend class content::WebContentsUserData<HistoryTabHelper>;
44 45
45 // content::WebContentsObserver implementation. 46 // content::WebContentsObserver implementation.
46 void DidNavigateMainFrame( 47 void DidNavigateMainFrame(
47 const content::LoadCommittedDetails& details, 48 const content::LoadCommittedDetails& details,
48 const content::FrameNavigateParams& params) override; 49 const content::FrameNavigateParams& params) override;
49 void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host, 50 void DidNavigateAnyFrame(content::RenderFrameHost* render_frame_host,
50 const content::LoadCommittedDetails& details, 51 const content::LoadCommittedDetails& details,
51 const content::FrameNavigateParams& params) override; 52 const content::FrameNavigateParams& params) override;
52 void TitleWasSet(content::NavigationEntry* entry, bool explicit_set) override; 53 void TitleWasSet(content::NavigationEntry* entry, bool explicit_set) override;
53 void WebContentsDestroyed() override; 54 void WebContentsDestroyed() override;
54 55
55 // Helper function to return the history service. May return NULL. 56 // Helper function to return the history service. May return NULL.
56 HistoryService* GetHistoryService(); 57 HistoryService* GetHistoryService();
57 58
58 // Whether we have a (non-empty) title for the current page. 59 // Whether we have a (non-empty) title for the current page.
59 // Used to prevent subsequent title updates from affecting history. This 60 // Used to prevent subsequent title updates from affecting history. This
60 // prevents some weirdness because some AJAXy apps use titles for status 61 // prevents some weirdness because some AJAXy apps use titles for status
61 // messages. 62 // messages.
62 bool received_page_title_; 63 bool received_page_title_;
63 64
64 DISALLOW_COPY_AND_ASSIGN(HistoryTabHelper); 65 DISALLOW_COPY_AND_ASSIGN(HistoryTabHelper);
65 }; 66 };
66 67
67 #endif // CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_ 68 #endif // CHROME_BROWSER_HISTORY_HISTORY_TAB_HELPER_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/history_service.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698