Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: Source/bindings/core/v8/V8LazyEventListener.h

Issue 823263002: ScriptState used by EventListener::handleEvent() is wrong (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8LazyEventListener.h
diff --git a/Source/bindings/core/v8/V8LazyEventListener.h b/Source/bindings/core/v8/V8LazyEventListener.h
index 93edbc9c3557b107e476a7306a3a6a0328540e65..2c19a28bfadaed6feaee034dd6ea99b3bdd19a96 100644
--- a/Source/bindings/core/v8/V8LazyEventListener.h
+++ b/Source/bindings/core/v8/V8LazyEventListener.h
@@ -50,18 +50,13 @@ public:
return adoptRef(new V8LazyEventListener(functionName, eventParameterName, code, sourceURL, position, node, isolate));
}
- // V8LazyEventListener is always for the main world.
- virtual DOMWrapperWorld& world() const override { return DOMWrapperWorld::mainWorld(); }
-
- virtual void handleEvent(ExecutionContext*, Event*) override;
-
protected:
virtual void prepareListenerObject(ExecutionContext*) override;
private:
V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition&, Node*, v8::Isolate*);
- virtual v8::Local<v8::Value> callListenerFunction(v8::Handle<v8::Value> jsEvent, Event*) override;
+ virtual v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Handle<v8::Value>, Event*) override;
// Needs to return true for all event handlers implemented in JavaScript so that
// the SVG code does not add the event handler in both

Powered by Google App Engine
This is Rietveld 408576698