Source/bindings/core/v8/V8EventListener.h - Issue 823263002: ScriptState used by EventListener::handleEvent() is wrong

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8EventListener.h

Issue 823263002: ScriptState used by EventListener::handleEvent() is wrong (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8EventListener.h

diff --git a/Source/bindings/core/v8/V8EventListener.h b/Source/bindings/core/v8/V8EventListener.h

index cde134c563893a7c87f23518bcb7332626cb851b..99af611646b7423d548fac53dd9a059a030a7310 100644

--- a/Source/bindings/core/v8/V8EventListener.h

+++ b/Source/bindings/core/v8/V8EventListener.h

@@ -50,10 +50,8 @@ public:

protected:

V8EventListener(v8::Local<v8::Object> listener, bool isAttribute, ScriptState*);

- v8::Local<v8::Function> getListenerFunction(ExecutionContext*);

- virtual v8::Local<v8::Value> callListenerFunction(v8::Handle<v8::Value> jsEvent, Event*) override;

+ v8::Local<v8::Function> getListenerFunction(ScriptState*);

+ virtual v8::Local<v8::Value> callListenerFunction(ScriptState*, v8::Handle<v8::Value>, Event*) override;

};

} // namespace blink