Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 823113005: Report whether a reboot happened since the SRT asked for one. (Closed)

Created:
5 years, 11 months ago by MAD
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report whether a reboot happened since the SRT asked for one. BUG=450831 Committed: https://crrev.com/d1f7bbc03afac5ff0cc3e7fcca73ff92d1b955e7 Cr-Commit-Position: refs/heads/master@{#312652} Committed: https://crrev.com/7246d8c0b68e7ecbb81a7de72d580172580b3c37 Cr-Commit-Position: refs/heads/master@{#312989}

Patch Set 1 : #

Patch Set 2 : Fixed XP issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 4 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
MAD
As you suggested... BYE MAD
5 years, 11 months ago (2015-01-22 00:35:23 UTC) #4
robertshield
lgtm
5 years, 11 months ago (2015-01-22 00:50:24 UTC) #6
MAD
Thanks Robert, now on to waffles@ for a quick OWNERs review. Thanks! BYE MAD
5 years, 11 months ago (2015-01-22 15:43:59 UTC) #8
waffles
lgtm
5 years, 11 months ago (2015-01-22 16:14:19 UTC) #9
MAD
On 2015/01/22 16:14:19, waffles wrote: > lgtm Thanks! :-) BYE MAD
5 years, 11 months ago (2015-01-22 17:34:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823113005/40001
5 years, 11 months ago (2015-01-22 17:36:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 11 months ago (2015-01-22 19:20:30 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d1f7bbc03afac5ff0cc3e7fcca73ff92d1b955e7 Cr-Commit-Position: refs/heads/master@{#312652}
5 years, 11 months ago (2015-01-22 19:22:20 UTC) #14
jam
A revert of this CL (patchset #1 id:40001) has been created in https://codereview.chromium.org/874693003/ by jam@chromium.org. ...
5 years, 11 months ago (2015-01-23 23:57:16 UTC) #15
MAD
Sorry about that... Fixed!
5 years, 11 months ago (2015-01-24 00:40:06 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823113005/60001
5 years, 11 months ago (2015-01-24 00:42:15 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 11 months ago (2015-01-24 01:36:54 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 01:37:43 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7246d8c0b68e7ecbb81a7de72d580172580b3c37
Cr-Commit-Position: refs/heads/master@{#312989}

Powered by Google App Engine
This is Rietveld 408576698