Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: Source/WebCore/platform/audio/HRTFKernel.cpp

Issue 8231033: Merge 97214 - Heap buffer overflow in Webaudio FFTFrame::doFFT (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/WebCore/platform/audio/HRTFPanner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/platform/audio/HRTFKernel.cpp
===================================================================
--- Source/WebCore/platform/audio/HRTFKernel.cpp (revision 97216)
+++ Source/WebCore/platform/audio/HRTFKernel.cpp (working copy)
@@ -51,7 +51,10 @@
float* impulseP = channel->data();
- ASSERT(channel->length() >= analysisFFTSize);
+ bool isSizeGood = channel->length() >= analysisFFTSize;
+ ASSERT(isSizeGood);
+ if (!isSizeGood)
+ return 0;
// Check for power-of-2.
ASSERT(1UL << static_cast<unsigned>(log2(analysisFFTSize)) == analysisFFTSize);
« no previous file with comments | « no previous file | Source/WebCore/platform/audio/HRTFPanner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698