Source/bindings/tests/results/core/V8TestInterfaceNode.cpp - Issue 823093002: [bindings] Make v8_class::install[v8_class]Template use Local<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

Issue 823093002: [bindings] Make v8_class::install[v8_class]Template use Local<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

index d3f5eae0b43aef9164b7ca1e581b12c1820148db..e35e3a96bd451303e14eac9373deecf3ef892b2d 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

@@ -292,7 +292,7 @@ static const V8DOMConfiguration::MethodConfiguration V8TestInterfaceNodeMethods[

{"perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg", TestInterfaceNodeV8Internal::perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodCallback, TestInterfaceNodeV8Internal::perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodCallbackForMainWorld, 0, V8DOMConfiguration::ExposedToAllScripts},

};

-static void installV8TestInterfaceNodeTemplate(v8::Handle<v8::FunctionTemplate> functionTemplate, v8::Isolate* isolate)

+static void installV8TestInterfaceNodeTemplate(v8::Local<v8::FunctionTemplate> functionTemplate, v8::Isolate* isolate)

{

functionTemplate->ReadOnlyPrototype();