Issue 823053003: Fix for disabled color writes xp on n6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 823053003: Fix for disabled color writes xp on n6 (Closed)

Created:
5 years, 11 months ago by egdaniel

Modified:
5 years, 11 months ago

Reviewers:
joshualitt, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix for disabled color writes xp on n6 The N6 has some driver bug that is required us to give some value to gl_FragColor. The disabledColorWriteXP should not need to set any value in its shader, but to fix this crash this cl sets gl_FragColor to 0. BUG=445377 Committed: https://skia.googlesource.com/skia/+/be9588ade8e3dac0adc8e038c46de006ca21af48

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/gpu/effects/GrDisableColorXP.cpp	View		2 chunks	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

egdaniel

ptal since this is currently crashing most web pages on the n6

5 years, 11 months ago (2014-12-30 16:57:36 UTC) #2

joshualitt

On 2014/12/30 16:57:36, egdaniel wrote: > ptal since this is currently crashing most web pages ...

5 years, 11 months ago (2014-12-30 16:59:18 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823053003/1

5 years, 11 months ago (2014-12-30 17:34:36 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2014-12-30 17:42:51 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/be9588ade8e3dac0adc8e038c46de006ca21af48

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages