Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1663)

Issue 82303002: Send debug event info on Commit requests, not just GetUpdates requests. (Closed)

Created:
7 years, 1 month ago by maniscalco
Modified:
7 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@dont-clear-debug-info-2
Visibility:
Public.

Description

Send debug event info on Commit requests, not just GetUpdates requests. BUG=318439 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -13 lines) Patch
M sync/engine/commit.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M sync/engine/syncer_unittest.cc View 2 chunks +98 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
maniscalco
Hi Nicolas, would you please review this change? LMK if you think of a better ...
7 years, 1 month ago (2013-11-22 18:12:43 UTC) #1
Nicolas Zea
LGTM!
7 years, 1 month ago (2013-11-22 23:21:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maniscalco@chromium.org/82303002/1
7 years, 1 month ago (2013-11-22 23:48:22 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-23 01:47:18 UTC) #4
Message was sent while issue was closed.
Change committed as 236914

Powered by Google App Engine
This is Rietveld 408576698