Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 823003002: Removes "ui-sans" from the ChromeOS system UI default font list. (Closed)

Created:
5 years, 12 months ago by Jun Mukai
Modified:
5 years, 10 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes "ui-sans" from the ChromeOS system UI default font list. The ChromeOS system UI (rendered through HarfBuzz) now relies on gfx::RenderText::CreateSkiaTypeface(), and skia actually returns exactly same typeface for 'Noto Sans UI' and 'ui-sans' in the current configuration. ui-sans is simply redundant. BUG=444894 R=jshin@chromium.org Committed: https://crrev.com/550404a8be2b84c686ac855204c737233292fd41 Cr-Commit-Position: refs/heads/master@{#313189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M ui/strings/app_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ar.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_bn.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_hi.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ja.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_kn.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ko.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ml.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_mr.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_ta.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_te.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_th.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_zh-CN.xtb View 1 chunk +1 line, -1 line 0 comments Download
M ui/strings/translations/app_locale_settings_zh-TW.xtb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Jun Mukai
5 years, 12 months ago (2014-12-23 19:02:06 UTC) #1
Jun Mukai
Jungshik, could you take a look? Apart from the performance reason I wrote in the ...
5 years, 11 months ago (2015-01-20 21:23:22 UTC) #2
Jun Mukai
ping? Jungshik, could you review this?
5 years, 10 months ago (2015-01-26 22:38:15 UTC) #3
jungshik at Google
On 2015/01/20 21:23:22, Jun Mukai wrote: > Jungshik, could you take a look? > Apart ...
5 years, 10 months ago (2015-01-27 00:25:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/823003002/1
5 years, 10 months ago (2015-01-27 00:27:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 01:22:33 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 01:23:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/550404a8be2b84c686ac855204c737233292fd41
Cr-Commit-Position: refs/heads/master@{#313189}

Powered by Google App Engine
This is Rietveld 408576698