Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 822953003: Revert of remove unused SkAvoidXfermode (Closed)

Created:
5 years, 11 months ago by scroggo
Modified:
5 years, 11 months ago
Reviewers:
bsalomon, reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of remove unused SkAvoidXfermode (patchset #2 id:20001 of https://codereview.chromium.org/860583002/) Reason for revert: Breaking Android framework build, which still uses AvoidXfermode. (failure shown here: https://android-build.storage.googleapis.com/builds/git_master-skia-linux-razor-userdebug/1689202/565b76b4bd8cc2ffd5aeb37e524f6a35e9b8791995d6e8c719a3a6d83aece936/logs/build_error.log?Signature=lHYyiconR%2BoTzY9ILAKlaUm6nFnpJQPTI4XUei1ZccBRyz6PxspCNvYCDO5za92yZSoy9refHT7uh2Hxlxew1ZBePxKCp2nnwJB7a%2B403kiHMHHawjecsbPnTE9QNNO8XMoqAjujcAplorhwsIBZYOCxb%2Bo5010BCfzTd%2F8GFa8%3D&Expires=1421764644&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com) Here is the Java class that uses it: https://cs.corp.google.com/#android/frameworks/base/graphics/java/android/graphics/AvoidXfermode.java&sq=package:android It has been deprecated. The glue code (which actually references the Skia file) is here: https://cs.corp.google.com/#android/frameworks/base/core/jni/android/graphics/Xfermode.cpp&q=Xfermode.cpp&sq=package:android Mike suggested we move the implementation into Android, which is fine with me. Original issue's description: > remove unused SkAvoidXfermode > > BUG=skia: > TBR= > NOTRY=True > > Committed: https://skia.googlesource.com/skia/+/2d02df7a9a50217dac8c1d11681832a927ed79ce TBR=bsalomon@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b2b416d3847c138a0a13876fdc1cdeae607b7e31

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -0 lines) Patch
M gyp/SampleApp.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A include/effects/SkAvoidXfermode.h View 1 chunk +68 lines, -0 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M samplecode/SampleAll.cpp View 2 chunks +13 lines, -0 lines 0 comments Download
A samplecode/SampleAvoid.cpp View 1 chunk +105 lines, -0 lines 0 comments Download
A src/effects/SkAvoidXfermode.cpp View 1 chunk +178 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_chromium.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scroggo
Created Revert of remove unused SkAvoidXfermode
5 years, 11 months ago (2015-01-20 14:32:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822953003/1
5 years, 11 months ago (2015-01-20 14:33:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/b2b416d3847c138a0a13876fdc1cdeae607b7e31
5 years, 11 months ago (2015-01-20 14:33:17 UTC) #3
scroggo
5 years, 10 months ago (2015-01-30 13:58:54 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/890893003/ by scroggo@google.com.

The reason for reverting is: Relanding, now that SkAvoidXfermode has been moved
into Android..

Powered by Google App Engine
This is Rietveld 408576698