Validate Bucket data in ShaderSourceBucket.

gpu/command_buffer/service/gles2_cmd_decoder.cc

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 9ad567a0cca020744f954861b956303151992022..4fb84aa716b2b487b5b69332b8a52e3c825aeca9 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -7090,6 +7090,11 @@ error::Error GLES2DecoderImpl::HandleShaderSourceBucket(
   if (!bucket || bucket->size() == 0) {
     return error::kInvalidArguments;
   }
+
+  if (!bucket->GetData(0, bucket->size() - 1)) {

[Zhenyao Mo, 2014/12/31 00:13:47]

Good catch.  But instead of checking it here, it makes more sense to strengthen
the CommonDecoder::Bucket::SetSize to handle mem allocation failure, i.e., when
mem alloc fails, set size to 0.

[sivag, 2014/12/31 11:22:19]

Done.

+    return error::kOutOfBounds;
+  }
+
   return ShaderSourceHelper(
       c.shader, bucket->GetDataAs<const char*>(0, bucket->size() - 1),
       bucket->size() - 1);