Issue 822903003: Fix math in view_manager's display_manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 822903003: Fix math in view_manager's display_manager (Closed)

Created:
5 years, 11 months ago by jamesr

Modified:
5 years, 11 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix math in view_manager's display_manager This fixes the math up translating from the view manager's view tree to a surfaces frame and renames variables to be more descriptive. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0f0f6dc872c0fa3462b351d5258119ac13f8c00a

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	services/view_manager/display_manager.cc	View		2 chunks	+11 lines, -8 lines	0 comments	Download

Total messages: 5 (1 generated)

jamesr

Hmm, we could but it'd take a bit of refactoring. I'll land this first to ...

5 years, 11 months ago (2015-01-05 21:45:49 UTC) #4

jamesr

5 years, 11 months ago (2015-01-05 21:46:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0f0f6dc872c0fa3462b351d5258119ac13f8c00a (presubmit successful).