Issue 8229003: Convert 'msvs_prebuild' and 'msvs_postbuild' for MSBuild (Visual C++ 2010).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8229003: Convert 'msvs_prebuild' and 'msvs_postbuild' for MSBuild (Visual C++ 2010). (Closed)

Created:
9 years, 2 months ago by yukawa_g

Modified:
7 years, 5 months ago

Reviewers:
jeanluc, M-A Ruel

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Translate 'msvs_prebuild' and 'msvs_postbuild' for MSBuild (Visual C++ 2010). Currently 'msvs_prebuild' and 'msvs_postbuild' settings in the gyp file are ignored when -G msvs_version=2010 is specified. This CL allows the msvs generator to translate these settings into <PreBuildEvent> and <PostBuildEvent> respectively.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -4 lines)			Patch
M	pylib/gyp/generator/msvs.py	View		3 chunks	+7 lines, -4 lines	0 comments	Download
A	test/msvs/buildevents/buildevents.gyp	View		1 chunk	+14 lines, -0 lines	0 comments	Download
A	test/msvs/buildevents/gyptest-all.py	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	test/msvs/buildevents/main.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

yukawa_g

Hi Jean-Luc, Currently 'msvs_prebuild' and 'msvs_postbuild' settings in the gyp file are ignored when -G ...

9 years, 2 months ago (2011-10-11 08:45:23 UTC) #1

M-A Ruel

9 years, 2 months ago (2011-10-11 13:57:07 UTC) #2

On 2011/10/11 08:45:23, yukawa wrote:
> Currently 'msvs_prebuild' and 'msvs_postbuild' settings in the gyp file are
> ignored when -G msvs_version=2010 is specified.
> Can we use <PreBuildEvent> and <PostBuildEvent> element to support them?

These two functionality are really bad and are a maintenance burden. I'd prefer
them to not be implemented. I'd prefer you to use actions instead.

Expand Messages | Collapse Messages