Source/core/frame/LocalDOMWindow.cpp - Issue 822863003: LifecycleObserver::contextDestroyed should be explicitly dispatched promptly when a context is dest…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 822863003: LifecycleObserver::contextDestroyed should be explicitly dispatched promptly when a context is dest… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalDOMWindow.cpp

diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp

index 0eb295eb957c3f684cf3e37a0385ced090dc1e5f..eea3020b6026dff7989f703fd2ba5e78692d3418 100644

--- a/Source/core/frame/LocalDOMWindow.cpp

+++ b/Source/core/frame/LocalDOMWindow.cpp

@@ -580,6 +580,7 @@ void LocalDOMWindow::willDetachFrameHost()

{

frame()->host()->eventHandlerRegistry().didRemoveAllEventHandlers(*this);

frame()->host()->consoleMessageStorage().frameWindowDiscarded(this);

+ LifecycleContext<LocalDOMWindow>::contextDestroyed();

}

void LocalDOMWindow::willDestroyDocumentInFrame()

@@ -628,6 +629,8 @@ void LocalDOMWindow::reset()

#if ENABLE(ASSERT)

m_hasBeenReset = true;

#endif

+ LifecycleContext<LocalDOMWindow>::contextDestroyed();

}

bool LocalDOMWindow::isCurrentlyDisplayedInFrame() const

« no previous file with comments | « Source/core/dom/ExecutionContext.h ('k') | Source/core/page/Page.cpp » ('j') | no next file with comments »