Fix Website Settings crash with Plugins ASK setting.

Fix Website Settings crash with Plugins ASK setting.

This is a partial fix for 41, but this part can be merged to 39 and 40.
This should be merged to 39 and 40.

BUG=444524
Committed: https://crrev.com/5abc69b1a406999169052b7d457de86fd67c6f8c
Cr-Commit-Position: refs/heads/master@{#309561}

[tommycli, 2014-12-22 21:24:35]

tommycli@chromium.org changed reviewers:
+ markusheintz@chromium.org

[tommycli, 2014-12-22 21:30:48]

markusheintz: PTAL

This fixes a crash that exists in Stable all the way to Canary.

The issue is the Website Settings dropdown from the Lock icon did not support
the 'Ask' option for Plugins.

The 'Ask' option is being replaced by 'Detect' in M41, but this fix is needed to
make 39 and 40 behave correctly.

The 41 patch is separate, as it cannot by merged.

Thanks!

[markusheintz_, 2014-12-23 16:42:29]

On 2014/12/22 21:30:48, tommycli wrote:
> markusheintz: PTAL
> 
> This fixes a crash that exists in Stable all the way to Canary.
> 
> The issue is the Website Settings dropdown from the Lock icon did not support
> the 'Ask' option for Plugins.
> 
> The 'Ask' option is being replaced by 'Detect' in M41, but this fix is needed
to
> make 39 and 40 behave correctly.
> 
> The 41 patch is separate, as it cannot by merged.
> 
> Thanks!

Can you really merge string changes? Have you checked this with the release
managers?

Code LGTM

[tommycli, 2014-12-23 17:56:52]

On 2014/12/23 16:42:29, markusheintz_ wrote:
> On 2014/12/22 21:30:48, tommycli wrote:
> > markusheintz: PTAL
> > 
> > This fixes a crash that exists in Stable all the way to Canary.
> > 
> > The issue is the Website Settings dropdown from the Lock icon did not
support
> > the 'Ask' option for Plugins.
> > 
> > The 'Ask' option is being replaced by 'Detect' in M41, but this fix is
needed
> to
> > make 39 and 40 behave correctly.
> > 
> > The 41 patch is separate, as it cannot by merged.
> > 
> > Thanks!
> 
> Can you really merge string changes? Have you checked this with the release
> managers?
> 
> Code LGTM

Good point. I will need to talk to the release managers. This does fix a crash,
so maybe we can get it in somehow.

[tommycli, 2014-12-23 17:56:56]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-23 17:57:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/822823002/20001

[commit-bot: I haz the power, 2014-12-23 18:19:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-23 18:21:13]

Patchset 2 (id:??) landed as
https://crrev.com/5abc69b1a406999169052b7d457de86fd67c6f8c
Cr-Commit-Position: refs/heads/master@{#309561}