Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1772)

Unified Diff: content/browser/renderer_host/input/web_input_event_util_unittest.cc

Issue 822803005: Correct missing radius in ui::TouchEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK touch minor <= touch major Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/web_input_event_util_unittest.cc
diff --git a/content/browser/renderer_host/input/web_input_event_util_unittest.cc b/content/browser/renderer_host/input/web_input_event_util_unittest.cc
index 2587863d42801bfad960de6e4423b5811b6cee57..36fcbc7bc50926111c60c3825bffc3039d69ff4d 100644
--- a/content/browser/renderer_host/input/web_input_event_util_unittest.cc
+++ b/content/browser/renderer_host/input/web_input_event_util_unittest.cc
@@ -103,4 +103,19 @@ TEST(WebInputEventUtilTest, ScrollUpdateConversion) {
EXPECT_TRUE(web_event.data.scrollUpdate.previousUpdateInSequencePrevented);
}
+TEST(WebInputEventUtilTest, TouchMinorOfZeroUsesTouchMajor) {
+ const float nonZeroMajorAxisLength = 36;
+
+ // Test zeroed minor axis.
+ ui::PointerProperties pointer(5, 10, 40);
+ pointer.touch_major = nonZeroMajorAxisLength;
+ pointer.touch_minor = 0;
+ MotionEventGeneric event(
+ MotionEvent::ACTION_DOWN, base::TimeTicks::Now(), pointer);
+
+ WebTouchEvent actual_event = CreateWebTouchEventFromMotionEvent(event, false);
+ EXPECT_EQ(nonZeroMajorAxisLength / 2, actual_event.touches[0].radiusX);
+ EXPECT_EQ(nonZeroMajorAxisLength / 2, actual_event.touches[0].radiusY);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698