Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 822763005: Run app_shell_browsertests and app_shell_unittests on mac trybots and waterfall bots. (Closed)

Created:
6 years ago by Yoyo Zhou
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run app_shell_browsertests and app_shell_unittests on mac trybots and waterfall bots. BUG=399363 Committed: https://crrev.com/527e36e0910f9336cb02ac4ce5d96f4fcf3c4d6d Cr-Commit-Position: refs/heads/master@{#309817}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M testing/buildbot/chromium.mac.json View 4 chunks +8 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yoyo Zhou
6 years ago (2014-12-24 04:04:58 UTC) #2
Yoyo Zhou
dpranke: Can you review this? Paweł is OOO.
5 years, 11 months ago (2014-12-29 19:27:05 UTC) #4
Dirk Pranke
lgtm
5 years, 11 months ago (2014-12-31 04:14:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822763005/20001
5 years, 11 months ago (2014-12-31 18:08:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2014-12-31 18:21:40 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/527e36e0910f9336cb02ac4ce5d96f4fcf3c4d6d Cr-Commit-Position: refs/heads/master@{#309817}
5 years, 11 months ago (2014-12-31 18:22:40 UTC) #9
Avi (use Gerrit)
5 years, 11 months ago (2015-01-02 17:48:41 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/829093002/ by avi@chromium.org.

The reason for reverting is: Mac10.9 Tests (dbg) has been burning since this
landed, with consistent failures of a few dozen of the app_shell_browsertests:

failures:
AppViewTest.TestAppViewGoodDataShouldSucceed
HidApiTest.HidApp
HidApiTest.OnDeviceAdded
SystemMemoryApiTest.Memory
SystemCpuApiTest.Cpu
UsbApiTest.ListInterfaces
SystemDisplayApiTest.GetDisplay
SystemStorageEjectApiTest.EjectBadDeviceTest
UsbApiTest.TransferFailure
UsbApiTest.ResetDevice
SystemStorageApiTest.StorageAttachment
SystemStorageEjectApiTest.EjectTest
UsbApiTest.ZeroLengthTransfer
UsbApiTest.InvalidLengthTransfer
UsbApiTest.TransferEvent
UsbApiTest.DeviceHandling
DnsApiTest.DnsExtension
HidApiTest.OnDeviceRemoved
SystemNetworkApiTest.SystemNetworkExtension
SystemStorageApiTest.Storage
.

Powered by Google App Engine
This is Rietveld 408576698