Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: src/gpu/GrAAHairLinePathRenderer.cpp

Issue 822733003: Fix conics for gpu GrAAHairLinePathRender (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrAAHairLinePathRenderer.cpp
diff --git a/src/gpu/GrAAHairLinePathRenderer.cpp b/src/gpu/GrAAHairLinePathRenderer.cpp
index b8c44c72d57cd53ff3e6a8c6ab61175cb71dc3c8..1dd227aa9ebd31346607e652c19196b16d0e5bd5 100644
--- a/src/gpu/GrAAHairLinePathRenderer.cpp
+++ b/src/gpu/GrAAHairLinePathRenderer.cpp
@@ -37,7 +37,7 @@
// Each quadratic is rendered as a five sided polygon. This poly bounds
// the quadratic's bounding triangle but has been expanded so that the
// 1-pixel wide area around the curve is inside the poly.
-// If a,b,c are the original control points then the poly a0,b0,c0,c1,a1
+// If a,b,c are the original control points then the poly a0,a1,b0,c0,c1
bsalomon 2014/12/22 16:40:46 really? a1 connects to b0? otherwise, lgtm
egdaniel 2014/12/22 16:52:17 yeah we draw the two "skinny" triangles on the sid
bsalomon 2014/12/22 17:04:46 ok, i think the comment is describing the bounding
// that is rendered would look like this:
// b0
// b
@@ -943,11 +943,12 @@ bool GrAAHairLinePathRenderer::onDrawPath(GrDrawTarget* target,
}
if (conicCnt > 0) {
- GrDrawState::AutoRestoreEffects are(drawState);
SkAutoTUnref<GrGeometryProcessor> hairConicProcessor(
GrConicEffect::Create(color, kHairlineAA_GrProcessorEdgeType, *target->caps(),
newCoverage));
SkASSERT(hairConicProcessor);
+ GrDrawState::AutoRestoreEffects are(drawState);
+ target->setIndexSourceToBuffer(fQuadsIndexBuffer);
int conics = 0;
while (conics < conicCnt) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698