Fix various issues in RedirectToFileResourceHandler.

content/browser/loader/sync_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/sync_resource_handler.h"
 
 #include "base/logging.h"
 #include "content/browser/devtools/devtools_netlog_observer.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/loader/resource_message_filter.h"
@@ skipping 68 matching lines @@
   if (!info->filter())
     return false;
 
   if (rdh_->delegate()) {
     rdh_->delegate()->OnResponseStarted(
         request(), info->GetContext(), response, info->filter());
   }
 
   DevToolsNetLogObserver::PopulateResponseInfo(request(), response);
 
+  // If the parent handler downloaded the resource to a file, grant the child
+  // read permissions on it. Note: there is similar logic in
+  // AsyncResourceHandler.
+  //
+  // TODO(davidben): Can we remove support for download_file in sync requests

[darin (slow to review), 2014/03/11 05:15:58]

Yes, I believe we should be able to disallow support for downloading to a file
in the sync XHR case.

[davidben, 2014/03/11 19:50:04]

Alright. Let's do that in a follow-up, unless you prefer it in the same one.

+  // altogether? I don't think Blink ever makes such requests.
+  if (!response->head.download_file_path.empty()) {
+    rdh_->RegisterDownloadedTempFile(
+        info->GetChildID(), info->GetRequestID(),
+        response->head.download_file_path);
+  }
+
   // We don't care about copying the status here.
   result_.headers = response->head.headers;
   result_.mime_type = response->head.mime_type;
   result_.charset = response->head.charset;
   result_.download_file_path = response->head.download_file_path;
   result_.request_time = response->head.request_time;
   result_.response_time = response->head.response_time;
   result_.load_timing = response->head.load_timing;
   result_.devtools_info = response->head.devtools_info;
   return true;
@@ skipping 50 matching lines @@
 }
 
 void SyncResourceHandler::OnDataDownloaded(
     int request_id,
     int bytes_downloaded) {
   // Sync requests don't involve ResourceMsg_DataDownloaded messages
   // being sent back to renderers as progress is made.
 }
 
 }  // namespace content