content/renderer/render_view_impl.h - Issue 8227018: mac: Almost fix Lion accented character bubble input in web contents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 8227018: mac: Almost fix Lion accented character bubble input in web contents. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: whoopsies Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index c8cc69a6092e79fa32d889c9d0b51abeb6dffa63..873c739600ff52fa281f38aaa5b770122941b2f1 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -632,7 +632,8 @@ class RenderViewImpl : public RenderWidget,

const std::vector<WebKit::WebCompositionUnderline>& underlines,

int selection_start,

int selection_end) OVERRIDE;

- virtual void OnImeConfirmComposition(const string16& text) OVERRIDE;

+ virtual void OnImeConfirmComposition(

+ const string16& text, const ui::Range& replacement_range) OVERRIDE;

virtual ui::TextInputType GetTextInputType() OVERRIDE;

virtual bool CanComposeInline() OVERRIDE;

virtual bool WebWidgetHandlesCompositorScheduling() const OVERRIDE;